fix(cli,browser): robust browser state management and error handling #185
+82
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@arnonuem is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
• Fix CLI silently swallowing launch errors when using --headed/--proxy flags
by checking response.success, not just network errors
• Fix isLaunched() returning true for disconnected browsers by checking
browser.isConnected() and cleaning up stale state
• Add browser.on('disconnected') handler to proactively reset state when
browser crashes or is closed externally
Before: Closing browser window caused "Browser not launched. Call launch first"
error on next command, requiring manual close to recover.
After: Browser state is properly tracked; auto-relaunch works reliably.
Fixes zombie daemon state issue on Windows (and likely other platforms).
arnonuem
force-pushed
the
fix__browser-launch-reliability
branch
from
97c806a to
6c69928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fix CLI silently swallowing launch errors when using --headed/--proxy flags
by checking response.success, not just network errors
• Fix isLaunched() returning true for disconnected browsers by checking
browser.isConnected() and cleaning up stale state
• Add browser.on('disconnected') handler to proactively reset state when
browser crashes or is closed externally
Before: Closing browser window caused "Browser not launched. Call launch first" error on next command, requiring manual close to recover.
After: Browser state is properly tracked; auto-relaunch works reliably.
Fixes zombie daemon state issue on Windows (and likely other platforms).