Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Fix incorrect tracking id on ProductOption's / ProductOption list per page switch #3368

Conversation

kamil-maslowski
Copy link
Contributor

Description

This issue occurs only when there is an option group with more than 10 options AND ProductOption has Custom fields.

In such case there are two problems when trying to navigate through option pages / update options custom fields:

  1. Per page selector doesn't work, thus it always stays at 10 items per page
  2. When switching pages using page selector, custom fields on pages > 1 binds to options from first page, cause ngFor gets an index as a tracking value

Breaking changes

PR doesn't include any breaking changes

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 14, 2025 4:10pm

Copy link
Contributor

github-actions bot commented Feb 14, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@kamil-maslowski
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

@michaelbromley michaelbromley added this to the v3.1.5 milestone Mar 5, 2025
@michaelbromley michaelbromley merged commit 33cfea6 into vendure-ecommerce:master Mar 5, 2025
31 checks passed
@michaelbromley
Copy link
Member

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: 💯 Ready
Development

Successfully merging this pull request may close these issues.

2 participants