Skip to content

[1.18] Deprecate inactive maintained packages#9912

Merged
ywk253100 merged 5 commits into
velero-io:release-1.18from
blackpiglet:jxun/1.18/deprecate_inactive_packages
Jul 10, 2026
Merged

[1.18] Deprecate inactive maintained packages#9912
ywk253100 merged 5 commits into
velero-io:release-1.18from
blackpiglet:jxun/1.18/deprecate_inactive_packages

Conversation

@blackpiglet

@blackpiglet blackpiglet commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Replace k8s.io/utils/pointer with k8s.io/utils/ptr

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
Move the needed code into Velero repository.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@blackpiglet blackpiglet self-assigned this Jun 12, 2026
@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 12, 2026
@github-actions github-actions Bot requested review from Lyndon-Li and sseago June 12, 2026 09:33
@github-actions github-actions Bot added Dependencies Pull requests that update a dependency file has-unit-tests has-e2e-2tests labels Jun 12, 2026
@blackpiglet blackpiglet changed the title [1.18] Deprecate inactive maintained packages [WIP][1.18] Deprecate inactive maintained packages Jun 12, 2026
@blackpiglet blackpiglet marked this pull request as draft June 12, 2026 09:39
@blackpiglet blackpiglet force-pushed the jxun/1.18/deprecate_inactive_packages branch from 1c06710 to e21273e Compare June 12, 2026 09:45
Change errors.Cause to errors.Is, because github.com/cockroachdb/errors
New() function create a error with error stack with depth 1, but
github.com/pkg/errors's New() function create error with no depth.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@blackpiglet blackpiglet force-pushed the jxun/1.18/deprecate_inactive_packages branch from e21273e to 7047001 Compare June 12, 2026 10:01
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.15789% with 92 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/util/dotenv/dotenv.go 0.00% 85 Missing ⚠️
pkg/plugin/framework/common/server_errors.go 0.00% 6 Missing ⚠️
pkg/plugin/framework/common/handle_panic.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@blackpiglet blackpiglet changed the title [WIP][1.18] Deprecate inactive maintained packages [1.18] Deprecate inactive maintained packages Jun 29, 2026
@blackpiglet blackpiglet marked this pull request as ready for review June 29, 2026 06:15
@github-actions github-actions Bot requested review from reasonerjt and ywk253100 June 29, 2026 06:15
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>

@shubham-pampattiwar shubham-pampattiwar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here. Just wanted to understand, is there a specific reason this targets release-1.18 rather than main? For dependency replacements of this scope (300+ files), we'd usually land on main first to let it bake before backporting. Happy to be corrected if there's context I'm missing.

@blackpiglet

blackpiglet commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the work here. Just wanted to understand, is there a specific reason this targets release-1.18 rather than main? For dependency replacements of this scope (300+ files), we'd usually land on main first to let it bake before backporting. Happy to be corrected if there's context I'm missing.

The same change was already merged into the main branch before in #9890.

@ywk253100 ywk253100 merged commit 25402b6 into velero-io:release-1.18 Jul 10, 2026
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants