Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump vega #9515

Merged
merged 2 commits into from
Jan 29, 2025
Merged

chore: bump vega #9515

merged 2 commits into from
Jan 29, 2025

Conversation

lsh
Copy link
Member

@lsh lsh commented Jan 24, 2025

PR Description

Checklist
  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@lsh lsh requested a review from a team as a code owner January 24, 2025 20:27
domoritz
domoritz approved these changes Jan 25, 2025
View reviewed changes
package.json
"yargs": "~17.7.2"
},
"peerDependencies": {
"vega": "^5.24.0"
"vega": "^5.31.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we require this? I'd say let's be conservatives and only update the constraint here if we know of a functionality we need.

@domoritz
Copy link
Member

I rebased to main which hopefully fixes puppeteer/puppeteer#12818

@domoritz domoritz merged commit 37d2f09 into main Jan 29, 2025
9 checks passed
@domoritz domoritz deleted the vega-v5.31.0 branch January 29, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsh @domoritz