Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add NoInfer to IntrinsicNodeParser #2133

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix: add NoInfer to IntrinsicNodeParser #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d53a86
fix: add NoInfer to IntrinsicNodeParser
EladBezalel Dec 13, 2024
ca5331b
add tests
EladBezalel Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/NodeParser/IntrinsicNodeParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const intrinsicMethods: Record<string, ((v: string) => string) | undefine
Lowercase: (v) => v.toLowerCase(),
Capitalize: (v) => v[0].toUpperCase() + v.slice(1),
Uncapitalize: (v) => v[0].toLowerCase() + v.slice(1),
NoInfer: (v) => v,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

};

export class IntrinsicNodeParser implements SubNodeParser {
Expand Down
2 changes: 2 additions & 0 deletions test/valid-data/string-literals-intrinsic/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ type ResultUpper = Uppercase<Result>;
type ResultLower = Lowercase<ResultUpper>;
type ResultCapitalize = Capitalize<Result>;
type ResultUncapitalize = Uncapitalize<ResultCapitalize>;
type ResultNoInfer = NoInfer<Result>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this isn't how NoInfer is intended to be used and is a flaky test since all other intrinsic types are string-dependent and NoInfer might not be.

Please create a separate test with a code like:

// (I wrote this out of my head)

function test<T>(value: NoInfer<T>): T { return value } 
// create a function with type constraints as well (test<T extends something>())

export const MyObject = {
  str: test('asd'),
  // more samples with objects, type references, and so on...
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but thanks for working in this <3


export interface MyObject {
result: Result;
resultUpper: ResultUpper;
resultLower: ResultLower;
resultCapitalize: ResultCapitalize;
resultUncapitalize: ResultUncapitalize;
resultNoInfer: ResultNoInfer;
}
12 changes: 11 additions & 1 deletion test/valid-data/string-literals-intrinsic/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,24 @@
"SUCCESS"
],
"type": "string"
},
"resultNoInfer": {
"enum": [
"ok",
"fail",
"ABORT",
"Success"
],
"type": "string"
}
},
"required": [
"result",
"resultUpper",
"resultLower",
"resultCapitalize",
"resultUncapitalize"
"resultUncapitalize",
"resultNoInfer"
],
"type": "object"
}
Expand Down
Loading