[1.20.1] Implement Refabricated Skillet tweaks. #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request contains two major changes to the skillet item.
If you would like to request postponement (1.3 probably?) or removal of Skillet Flipping and just have the progress bar, I'd be happy to make a new PR.
Swap Skillets to a BEWLR
The previous solution of creating a load of models was overengineered. It'd be best to create a BEWLR and handle skillet rendering through this, this PR just brings this change from 1.21.1 over here.
Skillet Progress Bar
The Skillet now displays a progress bar instead of its durability whilst cooking.
This is a relatively light change, all things considered, and should not break anything.
Skillet Flipping
Skillet Flipping has been reworked heavily ever since #911.
The Skillet now also moves, the flipped food is only flipped 180 degrees rather than 360 degrees, and the movements are faster and less drastic in comparison to before.
You may activate this by pressing the
Attackkey whilst cooking with a skillet.This is a breaking change on the user's end, as it adds a network handler so a packet may be sent to activate the skillet flip.
In first person:
In third person: