perf(stats): add bank_id to memory_links for direct filtering#718
Merged
nicoloboschi merged 1 commit intomainfrom Mar 27, 2026
Merged
perf(stats): add bank_id to memory_links for direct filtering#718nicoloboschi merged 1 commit intomainfrom
nicoloboschi merged 1 commit intomainfrom
Conversation
The stats endpoint JOINs memory_links to memory_units just to filter by bank_id. With 8.2M+ links per bank this takes 18+ seconds, and the control plane polls every 10s — perpetually blocking the server. Add bank_id column directly to memory_links so the query can filter on ml.bank_id instead of mu.bank_id, letting Postgres push the filter down before the JOIN. - Migration: add bank_id TEXT NOT NULL, backfill from memory_units - All 4 INSERT paths (temporal, semantic, entity, causal) now write bank_id - Stats query filters on ml.bank_id instead of mu.bank_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bank_idcolumn tomemory_linkstable with migration (backfill frommemory_units)bank_idml.bank_idinstead ofmu.bank_id, letting Postgres push the filter before the JOINProblem
The stats endpoint JOINs
memory_linkstomemory_unitsjust to filter bybank_id. With 8.2M+ links per bank this takes 18+ seconds, and the control plane polls every 10s — perpetually blocking the server.Test plan