fix(python-client): expose all configurable fields in update_bank_config()#712
Merged
nicoloboschi merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
…fig() Add 10 missing bank-configurable fields to update_bank_config(): - entity_labels, entities_allow_free_form - consolidation_llm_batch_size, consolidation_source_facts_max_tokens, consolidation_source_facts_max_tokens_per_observation - retain_default_strategy, retain_strategies - reflect_source_facts_max_tokens - mcp_enabled_tools - llm_gemini_safety_settings Previously these could only be set via raw PATCH to /config. All new params are keyword-only with None defaults (backwards compatible).
nuclon
pushed a commit
to verifi-finance/hindsight
that referenced
this pull request
Mar 26, 2026
…fig() (vectorize-io#712) Add 10 missing bank-configurable fields to update_bank_config(): - entity_labels, entities_allow_free_form - consolidation_llm_batch_size, consolidation_source_facts_max_tokens, consolidation_source_facts_max_tokens_per_observation - retain_default_strategy, retain_strategies - reflect_source_facts_max_tokens - mcp_enabled_tools - llm_gemini_safety_settings Previously these could only be set via raw PATCH to /config. All new params are keyword-only with None defaults (backwards compatible).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_bank_config():entity_labels,entities_allow_free_form,consolidation_llm_batch_size,consolidation_source_facts_max_tokens,consolidation_source_facts_max_tokens_per_observation,retain_default_strategy,retain_strategies,reflect_source_facts_max_tokens,mcp_enabled_tools,llm_gemini_safety_settings/v1/default/banks/{id}/config— now the high-level wrapper has full parity with the server's configurable fieldsNonedefaults (fully backwards compatible)Note:
create_bank()is not updated because the server'sCreateBankRequestmodel only accepts a fixed subset of fields. Users should callcreate_bank()thenupdate_bank_config()for the advanced fields.Test plan
inspect.signature— present with correct types and defaults