Track connected participants to set workflow configuration late #273
+98
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the behavior of the sil-kit-system-controller to allow individual participants to disconnect and reconnect before all required participants are connected, without requiring a restart of other participants or the system controller itself.
Key Changes:
- Changed participant tracking from a static list to a dynamic set-based approach that monitors connections/disconnections
- Deferred workflow configuration until all required participants are connected
- Added duplicate participant name validation at startup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/changelog/versions/latest.md | Documents the improved participant drop-out/rejoin behavior |
| Utilities/SilKitSystemController/SystemController.cpp | Implements dynamic participant tracking, deferred workflow configuration, and duplicate name validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: KonradBreitsprecherBkd <[email protected]>
VDanielEdwards
approved these changes
Nov 3, 2025
Member
VDanielEdwards
left a comment
VDanielEdwards
left a comment
There was a problem hiding this comment.
LGTM! 👍 It does make it much nicer to redo half of the setup, when you manually run a bunch of participants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
sil-kit-system-controllerimmediately propagates the required participants (viaSetWorkflowConfiguration) on startup. This defines a system state which is calculated locally on each participant. If one of the requires participant drops out, the system state isError. Now, a restart of all required participant and the system controller is needed. This behavior can be improved as the restart is actually not necessary.With this PR, the connected/disconnected participants are tracked and only when all required participants have connected,
SetWorkflowConfigurationis called. This allows single participants to drop out and rejoin without having to restart other participants or the system controller.