Skip to content

feat(axiom sink): Add trace data support to Axiom Configuration for the axiom sink #22935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

darach
Copy link
Contributor

@darach darach commented Apr 23, 2025

Summary

Enhance axiom sink to support trace data.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Configure Vector with an Otel source and inject traces.
Configure Vector with a HTTP sink configured for Axiom and verify traces are ingested to a dataset.
Configure Vector with Axiom sink and confirm configuration error for trace data.
Modify axiom sink to enable trace data.
Run updated Vector with Axiom sink and verify traces are ingested to the same dataset as the HTTP sink.

The following configuration is now legal and working in vector:

sources:
  opentelemetry:
    type: opentelemetry
    grpc:
      address: 0.0.0.0:4317
    http:
      address: 0.0.0.0:4318

sinks:
  axiom:
    type: axiom
    inputs:
      - opentelemetry.traces # Note only trace data subset from the source are propagated
    compression: gzip
    token: xaat-beefbeef-cafe-4444-cafe-feedfeedfeed
    dataset: vector_trace_to_axiom_dataset_via_vector_axiom_sink

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Apr 23, 2025
@darach
Copy link
Contributor Author

darach commented Apr 23, 2025

@jszwedko Let me know if I missed anything. Checks LGTM locally.

@darach darach marked this pull request as ready for review April 23, 2025 14:27
@darach darach requested a review from a team as a code owner April 23, 2025 14:27
@jszwedko jszwedko requested a review from pront April 23, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Axiom sink to support traces
1 participant