test(prices): tweak tests#97
Open
Vombato wants to merge 5 commits into
Open
Conversation
Replace malformed unit tests that used unsupported token/fiat values with valid scenarios that verify GBP conversion and case-insensitive input normalization. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep explicit unit coverage for unsupported token and fiat values, asserting structured error payload content instead of replacing those scenarios. Co-authored-by: Cursor <cursoragent@cursor.com>
Vombato
changed the title
Log schema validation failures as info to avoid warning noise for expected invalid inputs, while preserving warn level for operational oracle failures. Co-authored-by: Cursor <cursoragent@cursor.com>
Vombato
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenandfiatinputs ingetTokenFiatPricestructuredContentfields (token,fiat,source,price)invalid_enum_valueand the specific invalid value (btc/jpy)Test plan
npx jest --config jest.config.js tests/prices/get-token-fiat-price.unit.test.ts --runInBand