Skip to content
This repository was archived by the owner on Apr 28, 2026. It is now read-only.

feat: upgrade VeBetterPassport to V5 with per-round participation tracking#70

Merged
Agilulfo1820 merged 1 commit into
mainfrom
feat/ve-passport-new-storage
Apr 3, 2026
Merged

feat: upgrade VeBetterPassport to V5 with per-round participation tracking#70
Agilulfo1820 merged 1 commit into
mainfrom
feat/ve-passport-new-storage

Conversation

@Agilulfo1820
Copy link
Copy Markdown
Member

Summary

  • VeBetterPassport V5: Introduces per-round participation tracking with new storage mappings for distinct app counts (userRoundAppCount), per-app action counts (appRoundActionCount), per-user-per-app action counts (userAppRoundActionCount), and total per-user action counts (userRoundActionCount)
  • Storage access refactor: Moves getPassportStorage() from the contract into PassportStorageTypes library, allowing all passport libraries to access storage directly instead of receiving it as a parameter — cleaner signatures and reduced calldata
  • New view functions: appRoundActionCount, userRoundAppCount, userRoundActionCount, userRoundActionCountApp, userUniqueAppInteraction, userInteractedApps exposed on the interface
  • Removed registerAggregatedActionsForRound: No longer needed with the new tracking approach
  • Deprecated V4: Previous version preserved under deprecated/V4/ with all its libraries and interface
  • CI: Reorganized and expanded test shards for better parallelism (split VeBetterPassport, Governance, GalaxyMember, and others into finer-grained shards)

Test plan

  • New round-tracking.test.ts covers userRoundAppCount, userRoundActionCount, appRoundActionCount, and userRoundActionCountApp (distinct app dedup, multi-app, multi-round, delegation)
  • Existing upgrade tests updated for V5 initialization
  • Existing VeBetterPassport tests updated for refactored library signatures
  • CI shard matrix updated — verify all shards pass

🤖 Generated with Claude Code

@Agilulfo1820 Agilulfo1820 requested a review from a team as a code owner April 3, 2026 08:45
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.38220% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../contracts/ve-better-passport/VeBetterPassport.sol 96.11% 4 Missing ⚠️
...better-passport/libraries/PassportConfigurator.sol 73.33% 4 Missing ⚠️
...tter-passport/libraries/PassportSignalingLogic.sol 95.23% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Agilulfo1820 Agilulfo1820 merged commit 4680504 into main Apr 3, 2026
56 checks passed
@Agilulfo1820 Agilulfo1820 deleted the feat/ve-passport-new-storage branch April 3, 2026 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants