Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR main changes to release/v1.7 #2740

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Nov 13, 2024

Description

SSIA

Related Issue

Versions

  • Vald Version: v1.7.14
  • Go Version: v1.23.3
  • Rust Version: v1.82.0
  • Docker Version: v27.3.1
  • Kubernetes Version: v1.31.2
  • Helm Version: v3.16.2
  • NGT Version: v2.3.4
  • Faiss Version: v1.9.0

Checklist

Special notes for your reviewer

Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

48 files out of 154 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1aecda8
Status: ✅  Deploy successful!
Preview URL: https://ae93df42.vald.pages.dev
Branch Preview URL: https://backport-main-release-v1-7.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 16.03774% with 445 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.7@e0d832c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/net/quic/conn.go 0.00% 121 Missing ⚠️
internal/client/v1/client/discoverer/discover.go 0.00% 67 Missing ⚠️
internal/core/algorithm/ngt/ngt.go 15.58% 65 Missing ⚠️
internal/net/quic/listener.go 0.00% 46 Missing ⚠️
pkg/discoverer/k8s/service/discover.go 0.00% 39 Missing ⚠️
internal/servers/server/server.go 38.00% 22 Missing and 9 partials ⚠️
internal/net/dialer.go 52.63% 13 Missing and 5 partials ⚠️
internal/sync/singleflight/singleflight.go 20.00% 12 Missing ⚠️
pkg/agent/core/ngt/service/ngt.go 14.28% 12 Missing ⚠️
internal/net/grpc/option.go 0.00% 11 Missing ⚠️
... and 7 more
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.7    #2740   +/-   ##
===============================================
  Coverage                ?   23.89%           
===============================================
  Files                   ?      547           
  Lines                   ?    54660           
  Branches                ?        0           
===============================================
  Hits                    ?    13059           
  Misses                  ?    40816           
  Partials                ?      785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpango kpango requested review from a team, kmrmt and vankichi and removed request for a team November 13, 2024 08:08
@kpango kpango merged commit 667eecf into release/v1.7 Nov 13, 2024
219 of 226 checks passed
@kpango kpango deleted the backport/main/release/v1.7 branch November 13, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants