-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] agent service test #2620
Conversation
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
+ Coverage 23.36% 24.24% +0.87%
==========================================
Files 531 533 +2
Lines 44740 46255 +1515
==========================================
+ Hits 10455 11214 +759
- Misses 33665 34289 +624
- Partials 620 752 +132 ☔ View full report in Codecov by Sentry. |
WalkthroughWalkthroughThe changes include the removal of an import statement for Changes
Sequence Diagram(s)sequenceDiagram
participant Test as ngt_test.go
participant K8s as kvar
Test->>K8s: Use Kubernetes-related functionality
Note right of K8s: Removed dependency on vald
Possibly related PRs
Suggested labels
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (3)
Files selected for processing (38)
Files not reviewed due to no reviewable changes (4)
Files skipped from review due to trivial changes (27)
Additional context usedGitHub Check: codecov/patch
Additional comments not posted (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: kpango <[email protected]>
9eb5d4a
53b5261
to
9eb5d4a
Compare
Deploying vald with Cloudflare Pages
|
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
* implement richer error model Signed-off-by: Kosuke Morimoto <[email protected]> * fix Signed-off-by: Kosuke Morimoto <[email protected]> * bug fix Signed-off-by: Kosuke Morimoto <[email protected]> * format Signed-off-by: Kosuke Morimoto <[email protected]> * add pkg-config Signed-off-by: Kosuke Morimoto <[email protected]> * delete comment out include Signed-off-by: Kosuke Morimoto <[email protected]> * Add UpdateTimestamp API (#2605) Signed-off-by: kpango <[email protected]> * [Bugfix] agent service test (#2620) Signed-off-by: kpango <[email protected]> * implement richer error model Signed-off-by: Kosuke Morimoto <[email protected]> * fix Signed-off-by: Kosuke Morimoto <[email protected]> * format Signed-off-by: Kosuke Morimoto <[email protected]> * resolve conflict Signed-off-by: Kosuke Morimoto <[email protected]> * resolve conflict Signed-off-by: Kosuke Morimoto <[email protected]> * revert Signed-off-by: Kosuke Morimoto <[email protected]> --------- Signed-off-by: Kosuke Morimoto <[email protected]> Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kato <[email protected]>
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
New Features
Chores
Documentation