Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpdateTimestamp API #2605

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add UpdateTimestamp API #2605

merged 3 commits into from
Sep 12, 2024

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 10, 2024

Description

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.0
  • Rust Version: v1.80.0
  • Docker Version: v27.1.1
  • Kubernetes Version: v1.30.3
  • Helm Version: v3.15.3
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

Checklist

Special notes for your reviewer

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

USER root:root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [hadolint] <DL3002> reported by reviewdog 🐶
Last USER should not be root

.github/workflows/reviewdog.yml
.github/workflows/labeler.yaml
.github/workflows/release.yaml
.github/workflows/reviewdog-hadolint.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[file name cspell] reported by reviewdog 🐶
Unknown word (textlintrc) Suggestions: []

Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

78 files out of 234 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3849920
Status: ✅  Deploy successful!
Preview URL: https://4483f4e2.vald.pages.dev
Branch Preview URL: https://feature-api-update-timestamp.vald.pages.dev

View logs

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 14.48087% with 313 lines in your changes missing coverage. Please review.

Project coverage is 23.36%. Comparing base (0e12419) to head (3849920).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hack/cspell/main.go 0.00% 150 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/update.go 0.00% 79 Missing ⚠️
pkg/agent/core/faiss/service/faiss.go 0.00% 34 Missing ⚠️
internal/client/v1/client/vald/vald.go 0.00% 21 Missing ⚠️
internal/backoff/backoff.go 23.07% 10 Missing ⚠️
internal/errors/agent.go 62.50% 6 Missing ⚠️
hack/docker/gen/main.go 0.00% 5 Missing ⚠️
...ernal/net/grpc/interceptor/client/metric/metric.go 0.00% 2 Missing ⚠️
...ernal/net/grpc/interceptor/server/metric/metric.go 0.00% 2 Missing ⚠️
internal/circuitbreaker/options.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
- Coverage   24.37%   23.36%   -1.02%     
==========================================
  Files         531      531              
  Lines       45880    44740    -1140     
==========================================
- Hits        11185    10455     -730     
+ Misses      33944    33663     -281     
+ Partials      751      622     -129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hlts2
hlts2 previously approved these changes Sep 11, 2024
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kmrmt
kmrmt previously approved these changes Sep 11, 2024
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hlts2 hlts2 merged commit 3ba0002 into main Sep 12, 2024
178 of 207 checks passed
@hlts2 hlts2 deleted the feature/api/update-timestamp branch September 12, 2024 07:35
vdaas-ci pushed a commit that referenced this pull request Sep 12, 2024
kpango added a commit that referenced this pull request Sep 12, 2024
kpango added a commit that referenced this pull request Sep 12, 2024
kpango added a commit that referenced this pull request Sep 12, 2024
kmrmt pushed a commit that referenced this pull request Sep 13, 2024
kmrmt pushed a commit that referenced this pull request Sep 13, 2024
kmrmt pushed a commit that referenced this pull request Sep 13, 2024
kpango added a commit that referenced this pull request Sep 17, 2024
* implement richer error model

Signed-off-by: Kosuke Morimoto <[email protected]>

* fix

Signed-off-by: Kosuke Morimoto <[email protected]>

* bug fix

Signed-off-by: Kosuke Morimoto <[email protected]>

* format

Signed-off-by: Kosuke Morimoto <[email protected]>

* add pkg-config

Signed-off-by: Kosuke Morimoto <[email protected]>

* delete comment out include

Signed-off-by: Kosuke Morimoto <[email protected]>

* Add UpdateTimestamp API (#2605)

Signed-off-by: kpango <[email protected]>

* [Bugfix] agent service test (#2620)

Signed-off-by: kpango <[email protected]>

* implement richer error model

Signed-off-by: Kosuke Morimoto <[email protected]>

* fix

Signed-off-by: Kosuke Morimoto <[email protected]>

* format

Signed-off-by: Kosuke Morimoto <[email protected]>

* resolve conflict

Signed-off-by: Kosuke Morimoto <[email protected]>

* resolve conflict

Signed-off-by: Kosuke Morimoto <[email protected]>

* revert

Signed-off-by: Kosuke Morimoto <[email protected]>

---------

Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: kpango <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment