WIP Seasonal stats #734
Open
WIP Seasonal stats #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vck3000
reviewed
Jan 20, 2025
Comment on lines
+29
to
+38
| enum: [ | ||
| 'unranked', | ||
| 'iron', | ||
| 'bronze', | ||
| 'silver', | ||
| 'gold', | ||
| 'platinum', | ||
| 'diamond', | ||
| 'champion', | ||
| ], |
There was a problem hiding this comment.
Let's add the actual values of each of these brackets on the season model.
vck3000
reviewed
Jan 20, 2025
| 'diamond', | ||
| 'champion', | ||
| ], | ||
| }, |
There was a problem hiding this comment.
If you also decide to put the mappings in the db instead of the code constants, let's also make sure the server only pulls that mapping once on startup rather than on every game finish.
vck3000
reviewed
Jan 20, 2025
| }); | ||
|
|
||
| // compile schema into a model | ||
| const SeasonalStats = mongoose.model('seasonalStats', seasonalStatsSchema); |
There was a problem hiding this comment.
Suggested change
| const SeasonalStats = mongoose.model('seasonalStats', seasonalStatsSchema); | |
| const UserSeasonStats = mongoose.model('seasonalStats', seasonalStatsSchema); |
vck3000
reviewed
Jan 20, 2025
| }, | ||
| }); | ||
|
|
||
| // compile schema into a model |
There was a problem hiding this comment.
Consider if you want to add in any season-level aggregated statistics, e.g. total number of games played in a season.
vck3000
reviewed
Jan 20, 2025
| rankedGamesWon: number; | ||
| rankedGamesLost: number; | ||
| winRate: number; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.