Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating games played metric #708

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Conversation

kev306
Copy link
Collaborator

@kev306 kev306 commented Jul 7, 2024

Separate metric by game type: custom, matchmaking, private

@kev306 kev306 changed the base branch from master to bugfix/metrics July 7, 2024 08:09
src/gameplay/roomTypes.ts Outdated Show resolved Hide resolved
src/gameplay/roomTypes.ts Outdated Show resolved Hide resolved
src/metrics/gameMetrics.ts Outdated Show resolved Hide resolved
src/sockets/sockets.ts Outdated Show resolved Hide resolved
src/gameplay/game.ts Outdated Show resolved Hide resolved
src/gameplay/game.ts Outdated Show resolved Hide resolved
@@ -5,5 +5,6 @@ export const gamesPlayedMetric = new PromMetricCounter({
help: 'Total number of games played.',
labelOptions: {
status: new Set(['finished', 'voided']),
game_type: new Set(['custom', 'matchmaking', 'private']),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it something other than game_type. It can be easily confused with avalon / hunter or fab 4 or anything else.

How's something like "room_creation_type"?

On second thought, private games should probably be a separate metric.

Match made games vs custom games.
Within custom games, there's public and private. Idk on second thought if we should be mixing these into the same label.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from previous discussions have done a room_type which is matchmaking, public and private.

@kev306 kev306 changed the base branch from bugfix/metrics to master July 22, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants