-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating games played metric #708
base: master
Are you sure you want to change the base?
Conversation
combinations with 0
recursive solution
src/metrics/gameMetrics.ts
Outdated
@@ -5,5 +5,6 @@ export const gamesPlayedMetric = new PromMetricCounter({ | |||
help: 'Total number of games played.', | |||
labelOptions: { | |||
status: new Set(['finished', 'voided']), | |||
game_type: new Set(['custom', 'matchmaking', 'private']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call it something other than game_type
. It can be easily confused with avalon / hunter or fab 4 or anything else.
How's something like "room_creation_type"?
On second thought, private games should probably be a separate metric.
Match made games vs custom games.
Within custom games, there's public and private. Idk on second thought if we should be mixing these into the same label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from previous discussions have done a room_type which is matchmaking, public and private.
Separate metric by game type: custom, matchmaking, private