[WIP] Matchmaking Queue #559
Conversation
src/sockets/matchmaking.ts
Outdated
|
|
||
| // Add user to queue | ||
| addUserToQueue(username: string): void { | ||
| if (!(username in this.userQueue)) { |
There was a problem hiding this comment.
Could you use Array.includes() pls?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
src/sockets/matchmaking.ts
Outdated
| // Checks if number users in queue >= specified roomSize. | ||
| // If yes, returns the list of users and removes them from the queue. | ||
| // If < specified roomSize, returns null | ||
| checkRoomPossible(roomSize: number): string[] | null { |
There was a problem hiding this comment.
Let's remove the roomSize input here. If we need to configure anything for the lifetime of this object, let's do it in the constructor.
For this PR, lets just hard code to 6 players in this file.
src/sockets/matchmaking.ts
Outdated
| const users = this.userQueue.slice(0 , roomSize); | ||
| this.userQueue = this.userQueue.slice(roomSize); | ||
| return users; | ||
| } else return null; |
There was a problem hiding this comment.
Instead of returning null, let's return empty array.
| @@ -0,0 +1,33 @@ | |||
| export class Matchmaking { | |||
There was a problem hiding this comment.
| export class Matchmaking { | |
| export class MatchmakingQueue { |
src/sockets/matchmaking.ts
Outdated
| @@ -0,0 +1,33 @@ | |||
| export class Matchmaking { | |||
| userQueue: string[]; | |||
| it('should allow a user to be added to the queue', () => { | ||
| matchmaking.addUserToQueue('pronub'); | ||
|
|
||
| expect(matchmaking.userQueue).toContain('pronub'); |
There was a problem hiding this comment.
Update tests to not read into private member userQueue
|
|
||
| matchmaking.removeUser('pronub'); | ||
|
|
||
| expect(matchmaking.userQueue).not.toContain('pronub'); |
There was a problem hiding this comment.
Replace test with:
- Add 5 users
- No match
- Add 6th user
- Match
- Try to find another match, should be empty
| expect(matchmaking.userQueue).not.toContain('pronub'); | ||
| }); | ||
|
|
||
| it('should do nothing if the user is not in the queue', () => { |
There was a problem hiding this comment.
Doesn't crash if we remove a user who was never added (you can paraphrase this).
Added a matchmaking class to implement a queue system