Repository navigation
fix: surface post-sync republish failures in the UI - #131
Merged
Merged
Conversation
When the auto-republish triggered after a sync fails (e.g. expired Cloudflare credentials), the error was written to job.status briefly before being overwritten by "completed" — invisible at 500ms polling. - Add `republishError` field to SyncJob so the error persists independently of the sync completion status - SyncProgress now renders a warning banner after the job finishes when `republishError` is set, so the user always sees it Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vboctor
force-pushed
the
fix/republish-error-visibility
branch
from
May 22, 2026 05:32
e5cdf61 to
f26b7d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job.statusbriefly before being overwritten by"completed"— invisible at the 500 ms poll intervalrepublishErrorfield toSyncJobso the error persists independently of sync completion statusSyncProgressnow shows a warning banner after the job finishes whenrepublishErroris setRoot cause
The catch block in
startSyncJobsetjob.status = "republish failed: ..."then immediatelyjob.status = "completed"— both assignments happen before the next poll tick, so the error was always missed.Test plan
bun run cipasses ✅🤖 Generated with Claude Code