Skip to content

fix(chat): release held disclosure anchor when reader scrolls up #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiangchuanso wants to merge 1 commit into from
Closed

fix(chat): release held disclosure anchor when reader scrolls up #1855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/desktop/src/features/chat/transcript/hooks/useTranscriptScroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,11 @@ export function useTranscriptScroll({
});
lastScrollTopRef.current = el.scrollTop;
if (transition.releasedFollow) cancelFollowScroll();
// A reader scroll-up takes the viewport back from any held disclosure
// anchor, exactly as a real gesture does in `markScrollGesture`. Without
// this, a held anchor can still be restored by the ResizeObserver during a
// later stream and steal the reader's position.
if (transition.releasedFollow) releaseDisclosureAnchor();

@vastsa vastsa Oct 24, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is broader than the stated user-scroll case: releasedFollow can be true for a non-gesture layout clamp, which this handler immediately classifies as layout noise below. Releasing the disclosure anchor here can make the next observer frame lose the held title. The PR's E2E wheel event already bubbles to markScrollGesture, which releases the anchor earlier.

if (gesturing && transition.releasedFollow) {
pinnedRef.current = false;
setShowJump(true);
Expand All @@ -447,7 +452,7 @@ export function useTranscriptScroll({
setShowJump(transition.showJump);
}
rememberReadingPosition();
}, [cancelFollowScroll, reachTop, readingPositionPendingRef, readingWindow, rememberReadingPosition, scheduleFollowScroll]);
}, [cancelFollowScroll, reachTop, readingPositionPendingRef, readingWindow, rememberReadingPosition, releaseDisclosureAnchor, scheduleFollowScroll]);

// Send / retry / regenerate always re-pins follow mode so the new prompt and
// its stream stay in view, even if the user had scrolled up through history.
Expand Down