Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendable cleanup #271

Merged
merged 7 commits into from
Mar 18, 2025
Merged

Sendable cleanup #271

merged 7 commits into from
Mar 18, 2025

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Mar 18, 2025

These changes are now available in 2.14.0

SQLPostgresConfiguration is now Sendable, and Sendable warnings for the use of SQLDatabase.withSession(_:) have been fixed.

Additional changes:

  • Swift minimum bumped to 5.9
  • Several miscellaneous warnings fixed
  • Cleanup of tests
  • Minimal formatting pass on all code
  • Update API docs theme settings

@gwynne gwynne added the semver-minor Contains new APIs label Mar 18, 2025
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy March 18, 2025 17:38
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (99d09c4) to head (451d442).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/PostgresKit/PostgresDatabase+SQL.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   40.85%   42.08%   +1.22%     
==========================================
  Files          13       13              
  Lines         842      865      +23     
==========================================
+ Hits          344      364      +20     
- Misses        498      501       +3     
Files with missing lines Coverage Δ
Sources/PostgresKit/ConnectionPool+Postgres.swift 37.50% <ø> (ø)
...stgresKit/Deprecations/PostgresConfiguration.swift 0.00% <ø> (ø)
...stgresConnectionSource+PostgresConfiguration.swift 0.00% <ø> (ø)
...Deprecations/PostgresDatabase+SQL+Deprecated.swift 0.00% <ø> (ø)
Sources/PostgresKit/PostgresConnectionSource.swift 100.00% <100.00%> (ø)
Sources/PostgresKit/PostgresDataTranslation.swift 67.51% <ø> (+0.47%) ⬆️
Sources/PostgresKit/PostgresRow+SQL.swift 80.00% <100.00%> (+1.42%) ⬆️
Sources/PostgresKit/SQLPostgresConfiguration.swift 85.10% <ø> (+0.66%) ⬆️
Sources/PostgresKit/PostgresDatabase+SQL.swift 74.57% <0.00%> (+1.84%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs updating but otherwise LGTM

@gwynne gwynne merged commit f4d4b9e into main Mar 18, 2025
14 checks passed
@gwynne gwynne deleted the sendable-cleanup branch March 18, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants