Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update van_jsx #243

Merged
merged 4 commits into from
Jan 20, 2024
Merged

refactor: update van_jsx #243

merged 4 commits into from
Jan 20, 2024

Conversation

cqh963852
Copy link
Contributor

@cqh963852 cqh963852 commented Jan 20, 2024 •
edited
Loading

relate issue #233

  • move jsx function to createElement file
  • add setAttribute function
  • use onClick like instead onclick while use JSX tag
  • update children type to VanNode
  • add OrVanAttribute, make tag can accept (()=>T) | State<T> type

@Tao-VanJS PTAL

@cqh963852 cqh963852 mentioned this pull request Jan 20, 2024
Open
Tao-VanJS
Tao-VanJS reviewed Jan 20, 2024
View reviewed changes
Copy link
Member

@Tao-VanJS Tao-VanJS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cqh963852

addons/van_jsx/package.json Outdated
@@ -2,12 +2,13 @@
"name": "vanjs-jsx",
"version": "0.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we upgrade the version?

Copy link
Contributor Author

@cqh963852 cqh963852 Jan 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me upgrade it to 0.2.0

@Tao-VanJS Tao-VanJS merged commit 426063f into vanjs-org:main Jan 20, 2024
@Tao-VanJS
Copy link
Member

Thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tao-VanJS Tao-VanJS Tao-VanJS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqh963852 @Tao-VanJS