Block PrefillDecode LiteRT spikes before dead-end loads - #11
Merged
Conversation
Probe showed Backend.GPU non-stream create still fails (null function), so keep Qwen3/Ministral spikes visible but disable Load with a clear runtime reason and stop duplicating the error in progress + banner. Co-authored-by: Cursor <cursoragent@cursor.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Advisory notes (legacy
The legacy Files Reviewed (5 files)
Reviewed by deepseek-v4-pro · Input: 82.6K · Output: 18K · Cached: 803.2K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.litertlmspikes are PrefillDecode models. Default LiteRTBackend.GPU_ARTISANalways uses streamingModelAssets→Streaming kTfLitePrefillDecode models is not supported yet.Blob buffering does not help (runtime still streams). ProbedBackend.GPUnon-streamingcreateEnginepath — still fails withnull functionon current@litert-lm/coreweb wasm. ChatsendMessage(non-stream) is irrelevant because load never succeeds.litertRuntime: 'prefilldecode-unsupported', blockAiChat.load()before download, disable Load with “Runtime unsupported”, show a clear pre-load reason (not just Experimental), keep spikes in the catalog for honesty.Test plan
pnpm test -- tests/unit/guardrails.spec.ts(includes PrefillDecode block test)Made with Cursor