Fix Safari LiteRT chat: undefined is not a function - #10
Merged
Conversation
sendMessageStreaming returns a ReadableStream; Safari lacks asyncIterator, so for-await threw "undefined is not a function". Consume via getReader when needed. Co-authored-by: Cursor <cursoragent@cursor.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by deepseek-v4-pro · Input: 41.4K · Output: 8.5K · Cached: 162K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendMessageStreaming()returns aReadableStream._completeOnceLiteRTusedfor await...ofon it. Safari/WebKit often lacksReadableStream.prototype[Symbol.asyncIterator], so iteration throwsundefined is not a function (near '...s of a...')(matches the live Gemma 4 E2B LiteRT failure after sending e.g. "yo man").iterateMessageStream()— prefer async iteration when present, otherwise consume viagetReader(). Wire LiteRT streaming through that helper.asyncIterator) covering Safari’s shape; existing async-generator mocks still pass.Test plan
pnpm test -- tests/unit/guardrails.spec.ts— 102 passed (includes new Safari stream test)yo man, confirm streamed reply (no footer/undefined is not a functionerror)Made with Cursor