fix(datepicker): replace Sass imports with uses #6747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates Sass file imports to use the new @use syntax to resolve deprecation warnings from [email protected] in Angular v19.
- Replaced @import statements with @use in mixins.scss
- Updated bs-datepicker.scss to use @use for both variables and mixins
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/datepicker/utils/scss/mixins.scss | Replaced the @import for 'variables' with @use 'variables' as *. |
| src/datepicker/bs-datepicker.scss | Replaced @import for 'utils/scss/variables' and 'utils/scss/mixins' with their corresponding @use statements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Angular project uses this library, and after upgrading to Angular v19, Sass is reporting deprecation warnings when we run the project. The issue is that Angular v19 uses
[email protected], which deprecates any@importstatements. The fix is to just replace all@import '...';with@use '...' as *;in .scss files. Fortunately, there are only 3 instances of this in the codebase.PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.