Skip to content

fix: package.json types reference #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

joshvanallen
Copy link
Contributor

Fixes the type references to enable apps that wants to use moduleResolution:nodenext

I have an example repo that folks can use to play with that updates the package.json to the correct location. This uses 18.1.3 but the root package.json is still the same.

If we can, would love to apply this to 18.x.x as well.

Fixes the type references to enable apps that wants to use `moduleResolution:nodenext`
@joshvanallen
Copy link
Contributor Author

@valorkin and @lexasq, brand new contributor to this repo so not too sure if you already get alerts for new PRs. Sorry if you do for the double alerts!

@valorkin valorkin requested a review from Copilot May 26, 2025 15:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the package versions across all sub-packages and the documentation asset to 19.0.4.

  • Bump version from 19.0.3 to 19.0.4 in each src/*/package.json
  • Update root package.json and current-version.json in the docs

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

File Description
src/*/package.json (multiple) Updated "version" to 19.0.4
package.json Updated "version" to 19.0.4
apps/ngx-bootstrap-docs/.../current-version.json Updated "version" to 19.0.4
Comments suppressed due to low confidence (1)

package.json:3

  • The PR title mentions fixing type references for moduleResolution: nodenext, but no types or typings fields were updated in package.json. Please ensure each package.json has the correct types path to its declaration file (e.g., "types": "dist/index.d.ts") to support nodenext resolution.
"version": "19.0.4",

@valorkin valorkin requested a review from Copilot May 28, 2025 10:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version numbers in multiple package.json files as well as the current version file to enable module resolution using the nodenext option.

  • Bumps version from 19.0.3 to 19.0.4 across several packages
  • Updates the current-version.json file in the docs assets

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/rating/package.json Updated version number to 19.0.4
src/progressbar/package.json Updated version number to 19.0.4
src/positioning/package.json Updated version number to 19.0.4
src/popover/package.json Updated version number to 19.0.4
src/pagination/package.json Updated version number to 19.0.4
src/modal/package.json Updated version number to 19.0.4
src/mini-ngrx/package.json Updated version number to 19.0.4
src/locale/package.json Updated version number to 19.0.4
src/focus-trap/package.json Updated version number to 19.0.4
src/dropdown/package.json Updated version number to 19.0.4
src/datepicker/package.json Updated version number to 19.0.4
src/component-loader/package.json Updated version number to 19.0.4
src/collapse/package.json Updated version number to 19.0.4
src/chronos/package.json Updated version number to 19.0.4
src/carousel/package.json Updated version number to 19.0.4
src/buttons/package.json Updated version number to 19.0.4
src/alert/package.json Updated version number to 19.0.4
src/accordion/package.json Updated version number to 19.0.4
package.json Updated version number to 19.0.4 and schema config remains
apps/ngx-bootstrap-docs/src/assets/json/current-version.json Updated version number to 19.0.4

@valorkin
Copy link
Member

thx for help!

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (e77c928) to head (b888a7e).
Report is 17 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6743      +/-   ##
===============================================
+ Coverage        76.60%   76.80%   +0.20%     
===============================================
  Files              317      317              
  Lines            10748    10767      +19     
  Branches          2866     2807      -59     
===============================================
+ Hits              8233     8270      +37     
+ Misses            2514     2496      -18     
  Partials             1        1              

see 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a37ec9...b888a7e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valorkin valorkin merged commit 0220889 into valor-software:development May 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants