Add support for pushing images to Amazon ECR #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanxi Zhang <[email protected]>
|
Can you add an image of your own ECR registry with the published images to the PR description? |
Thank you for your suggestion, i just added a link to my own ECR repo |
|
The code looks good to me and I see that the unstable version of the image is updated everyday in your personal repo which is good. I'll take another look once we set up all the credentials 👍. |
Signed-off-by: Hanxi Zhang <[email protected]>
Co-authored-by: Nikhil Manglore <[email protected]> Signed-off-by: Hanxi Zhang <[email protected]>
Signed-off-by: Hanxi Zhang <[email protected]>
…tainer into clean-ecr-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17
Summary
This PR adds support for publishing Valkey container images to Amazon ECR Public Gallery
Required Secrets
For ECR publishing to work, the following repository secrets need to be configured:
AWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEYECR_REPOSITORY_ALIASTesting
Verified functionality by publishing to personal registries: