Skip to content

fix: Re-add logic where we check for acm hub present #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 18, 2026
Merged

fix: Re-add logic where we check for acm hub present #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/controller/pattern_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,9 +788,17 @@ func (r *PatternReconciler) finalizeObject(instance *api.Pattern) error {
// Initialize deletion phase if not set
if qualifiedInstance.Status.DeletionPhase == api.InitializeDeletion {
log.Printf("Initializing deletion phase")
if err := r.updateDeletionPhase(qualifiedInstance, api.DeleteSpokeChildApps); err != nil {
return err
if haveACMHub(r) {
if err := r.updateDeletionPhase(qualifiedInstance, api.DeleteSpokeChildApps); err != nil {
return err
}
} else {
// There is no acm/spoke, we can directly start cleaning up child apps (from hub)
if err := r.updateDeletionPhase(qualifiedInstance, api.DeleteHubChildApps); err != nil {
return err
}
}

return fmt.Errorf("initialized deletion phase, requeueing now")
}

Expand Down