feat: automated creation of Azure NAT Gateway#44
feat: automated creation of Azure NAT Gateway#44butler54 merged 1 commit intovalidatedpatterns:mainfrom
Conversation
sabre1041
force-pushed
the
azure-nat-gateway
branch
from
e9720cc to
010cd72
Compare
| - name: Get Azure credentials | ||
| kubernetes.core.k8s_info: | ||
| kind: Secret | ||
| namespace: openshift-cloud-controller-manager | ||
| name: azure-cloud-credentials | ||
| register: azure_credentials | ||
| retries: 20 | ||
| delay: 5 |
There was a problem hiding this comment.
Should we just make this a safe exit? if we are not on azure in the future a clean exit would be nice.
There was a problem hiding this comment.
I had been thinking about it, but we should holistically do it across the board
such as: https://github.com/sabre1041/coco-pattern/blob/main/ansible/configure-issuer.yaml
There was a problem hiding this comment.
Actually I agree. I'll raise an issue to chart the development of the feature as we discussed offline.
butler54
changed the title
butler54
changed the title
butler54
left a comment
butler54
left a comment
There was a problem hiding this comment.
One small change and we are good to go.
| ansible.builtin.set_fact: | ||
| azure_subscription_id: "{{ (azure_cloud_conf.resources[0]['data']['cloud.conf'] | from_json)['subscriptionId'] }}" | ||
| azure_tenant_id: "{{ (azure_cloud_conf.resources[0]['data']['cloud.conf'] | from_json)['tenantId'] }}" | ||
| azure_resource_group: "{{ (azure_cloud_conf.resources[0]['data']['cloud.conf'] | from_json)['resourceGroup'] }}" |
There was a problem hiding this comment.
needs to be vnetResourceGroup which is different to resourceGroup on ARO
There was a problem hiding this comment.
on PO azure it should be the same
Signed-off-by: Andrew Block <andy.block@gmail.com>
sabre1041
force-pushed
the
azure-nat-gateway
branch
from
3735b60 to
6b6a2b9
Compare
2 participants
Automation to create and associate an Azure NAT Gateway to the worker subnet to resolve #42