Merge pull request #2 from vadymshymko/develop

Fix bug with empty item style prop
vadymshymko · May 28, 2018 · d6d1126 · d6d1126
2 parents 8d33178 + 8663e63
commit d6d1126
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 22 deletions.
diff --git a/dist/Carousel.js b/dist/Carousel.js
diff --git a/dist/Carousel.js.map b/dist/Carousel.js.map
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/example/src/App.js b/example/src/App.js
@@ -69,9 +69,6 @@ class App extends Component {
                 backgroundColor: "#000",
                 color: "#fff",
               }}
-              onClick={() => {
-                console.log('item click');
-              }}
               key={index}
             >
               {index}

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "reactjs-simple-carousel",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Simple react.js carousel component",
   "main": "dist/index.js",
   "scripts": {

diff --git a/src/components/Carousel/index.jsx b/src/components/Carousel/index.jsx
@@ -84,6 +84,7 @@ class ReactJSSimpleCarousel extends Component {
 
     this.slides = [];
 
+    this.itemsListPosition = 0;
     this.itemsListTransition = null;
     this.isItemsListTransitionDisabled = false;
 
@@ -182,14 +183,6 @@ class ReactJSSimpleCarousel extends Component {
     return 0;
   }
 
-  getItemsListOffsetFromDOM = () => {
-    if (this.itemsList) {
-      return parseInt(this.itemsList.dataset.position || 0, 10);
-    }
-
-    return 0;
-  }
-
   getSlideIndexByListOffset = (listOffset) => {
     const {
       activeSlideIndex,
@@ -316,7 +309,7 @@ class ReactJSSimpleCarousel extends Component {
       clearTimeout(this.autoplayTimer);
     }
 
-    this.itemsList.dataset.position = newItemsListOffset;
+    this.itemsListPosition = newItemsListOffset;
     this.itemsList.style.transform = `translateX(${newItemsListOffset}px)`;
   }
 
@@ -394,7 +387,7 @@ class ReactJSSimpleCarousel extends Component {
         clearTimeout(this.autoplayTimer);
       }
     } else {
-      this.itemsList.dataset.position = -this.getItemsListOffsetBySlideIndex(validatedSlideIndex);
+      this.itemsListPosition = -this.getItemsListOffsetBySlideIndex(validatedSlideIndex);
       this.itemsList.style.transform = `translateX(${-this.getItemsListOffsetBySlideIndex(validatedSlideIndex)}px)`;
     }
   }
@@ -494,7 +487,7 @@ class ReactJSSimpleCarousel extends Component {
 
     const itemsListOffset = this.state.isInitialized
       ? `-${this.getItemsListOffsetBySlideIndex(validatedActiveSlideIndex)}px`
-      : this.getItemsListOffsetFromDOM();
+      : this.itemsListPosition;
 
     const itemsListWidthByItemsToShow = itemsToShow
       ? `${(100 * itemsCount) / itemsToShow}%`
@@ -547,7 +540,6 @@ class ReactJSSimpleCarousel extends Component {
             {...itemsListProps}
             onTouchStart={this.handleListTouchStart}
             onMouseDown={this.handleListMouseDown}
-            data-position={itemsListOffset}
             tabIndex="-1"
             role="presentation"
             ref={(node) => { this.itemsList = node; }}
@@ -559,10 +551,10 @@ class ReactJSSimpleCarousel extends Component {
                 style: {
                   width: itemWidth = null,
                   ...itemStyle
-                },
+                } = {},
                 role,
                 ...itemComponentProps
-              },
+              } = {},
               ...slideComponentData
             }, index) => ({
               props: {