golangci-lint: Add linter configuration and GH action #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Trangoni <[email protected]>
mjtrangoni
force-pushed
the
add-golangci-lint
branch
from
78c3eca to
ae1fc7b
Compare
Signed-off-by: Mario Trangoni <[email protected]>
See, Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout=30m] in [] ... Error: paramTypeCombine: func(fqdn string, domain string) string could be replaced with func(fqdn, domain string) string (gocritic) Error: paramTypeCombine: func(url string, method string, body io.Reader, config internal.Config) ([]byte, error) could be replaced with func(url, method string, body io.Reader, config internal.Config) ([]byte, error) (gocritic) Error: ptrToRefParam: consider `secretData' to be of non-pointer type (gocritic) Error: sprintfQuotedString: use %q instead of "%s" for quoted strings (gocritic) Error: line is 129 characters (lll) Error: should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx) Signed-off-by: Mario Trangoni <[email protected]>
mjtrangoni
force-pushed
the
add-golangci-lint
branch
from
5048405 to
ba5dcfc
Compare
mjtrangoni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vadimkim,
This PR adds a simple golangci-lint action run, adding a custom configuration for this project.
I tried to keep it simple, so no opinionated change was applied.