Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #219

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Refactoring #219

merged 6 commits into from
Oct 30, 2023

Conversation

tyshko-rostyslav
Copy link
Contributor

  • moved public API tests to public_api_tests module

@github-actions
Copy link

Benchmark for 43859b4

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1203.7±1.36ns 1211.0±2.14ns +0.61%
FullMerkleTree::override_range 3.0±0.01µs 3.1±0.01µs +3.33%
FullMerkleTree::set 1207.5±6.43ns 1212.2±2.54ns +0.39%
OptimalMerkleTree::compute_root 1421.5±2.54ns 1365.3±2.30ns -3.95%
OptimalMerkleTree::delete 1416.0±6.47ns 1359.3±1.19ns -4.00%
OptimalMerkleTree::get 28.1±0.20ns 27.9±0.19ns -0.71%
OptimalMerkleTree::override_range 6.9±0.02µs 6.8±0.03µs -1.45%
OptimalMerkleTree::set 1412.2±3.69ns 1366.6±1.80ns -3.23%

@github-actions
Copy link

Benchmark for 43859b4

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.02ns 2.0±0.00ns 0.00%
Pmtree::get 463.5±0.47ns 471.0±0.35ns +1.62%
Pmtree::override_range 185.4±18.93µs 174.4±8.13µs -5.93%
Pmtree::set 69.0±0.63µs 69.3±1.17µs +0.43%
Pmtree:delete 69.1±0.04µs 69.0±0.04µs -0.14%

@github-actions
Copy link

Benchmark for 4cbbc36

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1486.1±1.30ns 1486.2±1.07ns +0.01%
FullMerkleTree::override_range 3.7±0.01µs 3.7±0.01µs 0.00%
FullMerkleTree::set 1486.9±1.50ns 1487.5±1.48ns +0.04%
OptimalMerkleTree::compute_root 1665.7±2.35ns 1670.4±1.63ns +0.28%
OptimalMerkleTree::delete 1654.7±1.81ns 1655.0±2.37ns +0.02%
OptimalMerkleTree::get 30.4±0.08ns 31.3±0.04ns +2.96%
OptimalMerkleTree::override_range 8.4±0.01µs 8.4±0.01µs 0.00%
OptimalMerkleTree::set 1653.5±1.68ns 1664.4±44.65ns +0.66%

@github-actions
Copy link

Benchmark for 4cbbc36

Click to view benchmark
Test Base PR %
Pmtree::compute_root 3.1±0.21ns 3.0±0.21ns -3.23%
Pmtree::get 644.4±78.20ns 647.5±101.83ns +0.48%
Pmtree::override_range 301.0±27.46µs 304.3±33.82µs +1.10%
Pmtree::set 92.6±6.99µs 95.8±8.19µs +3.46%
Pmtree:delete 97.8±6.29µs 92.0±6.71µs -5.93%

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice change!

@tyshko-rostyslav tyshko-rostyslav merged commit 25f822e into master Oct 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants