Skip to content

Conversation

jouni
Copy link
Member

@jouni jouni commented Oct 3, 2025

Screenshot 2025-10-03 at 14 29 31

@jouni jouni requested a review from vursen October 6, 2025 08:34
@vursen
Copy link
Contributor

vursen commented Oct 6, 2025

The textarea currently has a very small clickable area, which makes it hard to be activated with a click. Other themes don't have this issue.

Screen.Recording.2025-10-06.at.15.44.08.mov

@jouni
Copy link
Member Author

jouni commented Oct 6, 2025

I updated the mouse cursor to text for the content part. Clicking that should focus the editor.

Copy link

sonarqubecloud bot commented Oct 6, 2025

@vursen
Copy link
Contributor

vursen commented Oct 6, 2025

nit: Is it intentional that the whole RTE flashes with a blue outline when opening the color picker? It looks a bit distracting.

Screen.Recording.2025-10-06.at.16.28.54.mov

Shouldn't the toolbar button get an outline instead?

@jouni
Copy link
Member Author

jouni commented Oct 6, 2025

Is it intentional that the whole RTE flashes with a blue outline when opening the color picker? It looks a bit distracting.

I would assume that the editor was already focused when the user opens the color picker, so it wouldn't be flashing.

I didn't want to have the whole component to have a focus outline when the keyboard focus is not in the actual editor, if it's in one of the toolbar buttons. But I also didn't want the outline to flash when the user uses the toolbar buttons with the mouse to style some selected text, for example, making something bold.

Shouldn't the toolbar button get an outline instead?

I don't think so. When they are focused with the keyboard, then they do.

@jouni jouni merged commit 2c7a153 into main Oct 6, 2025
9 checks passed
@jouni jouni deleted the feat/aura-rte branch October 6, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants