Skip to content

fix: dialog base styles max-width #10285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

fix: dialog base styles max-width #10285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75b28d3
fix: dialog base styles max-width
jouni Oct 2, 2025
b915688
fix unit tests
vursen Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dialog/src/styles/vaadin-dialog-overlay-base-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const dialogOverlayBase = css`
border-radius: var(--vaadin-dialog-border-radius, var(--vaadin-radius-l));
width: max-content;
min-width: min(var(--vaadin-dialog-min-width, 4em), 100%);
max-width: var(--vaadin-dialog-max-width, 100%);
max-width: min(var(--vaadin-dialog-max-width, 100%), 100%);
max-height: 100%;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/dialog/test/dialog.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ describe('vaadin-dialog', () => {
dialog.height = 400;
await nextRender();
expect(getComputedStyle(overlay.$.overlay).position).to.equal('relative');
expect(getComputedStyle(overlay.$.overlay).maxWidth).to.equal('100%');
expect(getComputedStyle(overlay.$.overlay).maxWidth).to.be.oneOf(['100%', 'min(100%, 100%)']);
});

it('should reset overlay width when set to null', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/dialog/test/draggable-resizable.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ describe('draggable', () => {
it('should not set overlay max-width to none on drag', async () => {
drag(container);
await nextRender();
expect(getComputedStyle(dialog.$.overlay.$.overlay).maxWidth).to.equal('100%');
expect(getComputedStyle(dialog.$.overlay.$.overlay).maxWidth).to.be.oneOf(['100%', 'min(100%, 100%)']);
});
});

Expand Down