(tweak/vrp) solved memory leak provoked by users_by_cid#55
Open
andreiciobanica wants to merge 1 commit intovRP-framework:mainfrom
Open
(tweak/vrp) solved memory leak provoked by users_by_cid#55andreiciobanica wants to merge 1 commit intovRP-framework:mainfrom
memory leak provoked by users_by_cid#55andreiciobanica wants to merge 1 commit intovRP-framework:mainfrom
Conversation
when you disconnect or quit, the data should not remain in `users_by_cid`
Collaborator
Boss-Man-Dev
left a comment
Boss-Man-Dev
left a comment
There was a problem hiding this comment.
further testing is needed to see if performance improved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the user data should not remain in
users_by_cidwhen the player actually quits the game/disconnects; this should solve a minormemory leakproblem or whoever usevRP.users_by_cidwith a storedcid;