ci: Migrate from pyright to mypy and fix types #442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced pyright with Astral's ty type checker and fixed all newly caught type issues. Changes: - Updated pyproject.toml: replaced pyright with ty (v0.0.7) - Created [tool.ty] configuration matching previous pyright settings - Updated Makefile: replaced 'pyright .' with 'ty check .' - Updated CLAUDE.md documentation to reference ty instead of pyright - Added uv extra-build-dependencies for django-positions and mysqlclient Fixed type issues identified by ty: - arch/views.py: Added queryset parameter to get_form() override - dashboard/views.py: Changed context |= to context.update() and fixed super().dispatch() call - markets/views.py: Added queryset parameter to get_object() overrides - opal/views.py: Changed setup() signature from AuthHttpRequest to HttpRequest and added isinstance check for has_early_access() - otisweb_testsuite/fixtures.py: Added str() cast for redirect_url - payments/views.py: Added queryset parameter to get_object() overrides - roster/forms.py: Added type: ignore for UnitChoiceField kwargs - rpg/levelsys.py: Changed LevelInfoDict = None to LevelInfoDict | None - rpg/views.py: Changed context |= to context.update() - suggestions/views.py: Changed super(CreateView, self) to super() All tests pass (173 passed).
Owner
Author
|
got excited but i think ty isn't ready for django yet unless i missed something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced pyright with Astral's ty type checker and fixed all newly caught type issues.