fix: actually fix roster test omfg #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_inquiry test was failing intermittently when run with pytest -n auto due to random subject assignment in UnitFactory. When units[19] (the 7th unit Alice tries to unlock) randomly got subject="K" (Secret), it would be auto- processed by the view logic at roster/views.py:351-352, even though the test expected it to NOT be auto-processed. The view auto-processes secret units (subject "K") regardless of the student's unlock count, which caused the test assertion to fail approximately 12.5% of the time (1 in 8 possible subjects). Fixed by explicitly creating units with non-secret subjects (A, C, G, N, F) instead of relying on random factory generation. The test later creates an explicit secret unit when testing that functionality.
…uiry
The previous fix introduced a new IntegrityError due to Unit's unique_together
constraint on (group, code). By creating only 5 UnitGroup objects and reusing
them for 20 Units, we hit a birthday paradox problem:
- Unit.code is randomly generated: choice("BDZ") + subject + choice("WXY")
- This gives only 9 possible codes per group (3 × 1 × 3)
- With 4 units per group (20 units ÷ 5 groups), probability of collision ≈ 54%
The fix: Create 20 separate UnitGroup objects (one per unit) to avoid any
possibility of code collision within a group. We still cycle through non-secret
subjects (A, C, G, N, F) to prevent the original flaky test issue where
subject="K" (Secret) would trigger auto-processing.
vEnhance
changed the title
vEnhance
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smh intern check your work