Add abstractions for alerting + Gmail and Grafana implementations #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides initial abstraction for sending alerts via different channels when a failure occurs.
Initial (WIP) implementation for sending emails via Gmail and POSTing alerts to Grafana are provided and wired in.
AlertsManager is responsible of transparently handling the initialization of different Alerter interface implementations, selectively enable only some of them and decide whether an alerting failure results in an application failure.
Having this layer of indirection should also make development of further, future, improvements easier.
Such as e.g. trying to dispatch alerts in a parallel manner.