Add RFC for CTAD in blocked_nd_range #1607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kboyarinov
commented
Jan 17, 2025
| If we add one more explicit deduction guide to support the code above, the single braced-init-list of size 2 or 3 would also match on this guide. | ||
|
|
||
| There are the following options how this issue can be resolved: | ||
| * Add a new deduction guide to support the code above. The downside of this approach is that it makes the ambiguity, discussed in the |
There was a problem hiding this comment.
My vision is that it would be better to pick that option since the explanation of the downside would not be surprise for the user and will be understandable from the deduction guides definition. I also think that construction of multi-dimensional ranges are mostly common use-case for blocked_nd_range.
The only thing that actually can be affected, is some generic code that can create both one and multi-dimensional ranges
kboyarinov
requested review from
vossmjp,
akukanov,
pavelkumbrasev and
rarutyun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference implementation is #1525
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information