Fix compilation on macOS with GCC. #1603
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes compilation on macOS with GCC (broken in 2022.0, worked fine in 2021.13). What's changed:
__TBB_WAITPKG_INTRINSICS_PRESENT
: it is now always defined totrue
on macOS and GCC (always fresh LLVM assembler, so the intrinsic is always present).-Wdeprecated-declarations
inco_context.h
: the warning was disabled with a Clang-specific pragma, replaced with Clang-compatible GCC version.With this changes it is possible to compile and run all tests:
Compilation with
BUILD_SHARED_LIBS=YES
still fails: the linker cannot find a vtable fordetail::r1::unsafe_wait
. This should be fixed separately.Fixes #1556
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
Other information