Range tests: scale sizes according to a policy #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do think I like this version better, it does things more concisely in the tests themselves, without having to call the same API multiple times. This PR also touches all the ranges tests, which is nice (though perhaps is something which could be done for the other strategy as well). |
|
|
||
| namespace test_std_ranges | ||
| { | ||
|
|
||
| inline constexpr std::size_t big_sz = (1<<25) + 10; //32M | ||
| inline constexpr int big_sz = (1<<24) + 10; //16M |
There was a problem hiding this comment.
It was 32M before.... What's a reason to changes it to 16M?
Don't we whether make test coverage worse?
There was a problem hiding this comment.
There are no specializations for more than 16M elements. So the coverage remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An approach alternative to #2078 (suggested in #2078 (comment))