cherry pick #2075 #2076
cherry pick #2075 #2076
Conversation
| Intel, the Intel logo, and Arc are the trademarks of Intel Corporation or its subsidiaries. | ||
|
|
There was a problem hiding this comment.
We already have a very similar claim at the line 10 above. Is it not sufficient?
There was a problem hiding this comment.
Perhaps we can just add "Arc" to the line 10 if we just want to call it out specifically?
There was a problem hiding this comment.
I double-checked the names database, and I made a mistake. This should be a footnote on the page where Arc products are cited, not on the Notices and Disclaimers page.
This line can be removed from the Notices and Disclaimers page and moved to a footnote on the Release Notes.
| @@ -20,7 +20,7 @@ New Features | |||
| with device policies for large data sizes. | |||
| - Improved performance of ``copy``, ``fill``, ``for_each``, ``replace``, ``reverse``, ``rotate``, ``transform`` and 30+ | |||
| other algorithms with device policies on GPUs. | |||
| - Improved oneDPL use with SYCL implementations other than Intel oneDPI DPC++/C++ compiler. | |||
| - Improved oneDPL use with SYCL implementations other than Intel® oneAPI DPC++/C++ Compiler. | |||
There was a problem hiding this comment.
We do not strictly need the trademark symbol here, because the line 7 of the Overview above already contains it, and it's sufficient to do just once for the document.
There was a problem hiding this comment.
@dcbenito looked at the context presented in the patch, which did not include the overview. The rule is known and confirmed by Dylan before: it is sufficient to have the trademark sign once for a name within the document.
This is in part the reason why the overview mentions both oneDPL and DPC++ by the official names: the trademark sign is already there and can be skipped in all the notes below.
There was a problem hiding this comment.
This is not totally correct. The Intel® oneAPI DPC++ Library/oneAPI DPC++ Library (Intel or open source) both have a short name "oneDPL" that can be used after the first instance of the full name, but the compiler Intel® oneAPI DPC++/C++ Compiler or oneAPI DPC++/C++ Compiler does not have a short name and should be used in its complete form. This is legal advice from the names database.
There was a problem hiding this comment.
I am speaking about the trademark symbol, not about the shorter form.
To make it clear, I do not consider this a critical problem; it can be clarified and resolved later.
There was a problem hiding this comment.
The latest advice is to cite the name in its completeness:
The approved usage is: Intel® oneAPI DPC++/C++ Compiler or oneAPI DPC++/C++ Compiler
NOTE: “If you are preparing documentation of the Intel-branded version of the product, use “Intel® oneAPI…” If you are documenting the industry specification, the open source project, or are making general references to the technology not specific to either the open source or Intel-branded product, use “oneAPI…”
- This name has been approved and adopted for internal and external use.
- This name should be used in its complete form, as noted above.
- Never abbreviate this name.
- Do not change the capitalization, unless used in a heading where normal capitalization rules apply.
- As noted above, the mark "Intel®" in front of this name is optional.
- No other trademark symbols (such as, ®, ™ or SM) should be used.
- Appropriate acknowledgement line for this name is “Intel and the Intel logo are trademarks of Intel Corporation or its subsidiaries.”
There was a problem hiding this comment.
Regarding "As noted above, the mark "Intel®" in front of this name is optional." The "optional" is for oneAPI products, in that the open source compiler does not use a (R), but the Intel branded version does.
There was a problem hiding this comment.
This whole discussion is kind of strange in the open-source repo of a UXL project, is not it? :) Switching to email.
| sizes of 4-8 million elements. | ||
| - ``sort``, ``stable_sort``, ``sort_by_key`` and ``stable_sort_by_key`` algorithms fail to compile | ||
| when using Clang 17 and earlier versions, as well as compilers based on these versions, | ||
| such as Intel(R) oneAPI DPC++/C++ Compiler 2023.2.0. | ||
| such as Intel® oneAPI DPC++/C++ Compiler 2023.2.0. |
There was a problem hiding this comment.
Similarly here we can just omit the trademark.
There was a problem hiding this comment.
Not correct. See above guidance.
Final cherry pick for release notes.