Optimize merge_sort algorithm for largest data sizes
#1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…introduce new function __find_start_point_in Signed-off-by: Sergey Kopienko <[email protected]>
…introduce __parallel_merge_submitter_large for merge of biggest data sizes Signed-off-by: Sergey Kopienko <[email protected]>
…using __parallel_merge_submitter_large for merge data equal or greater then 4M items Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
…fix compile error Signed-off-by: Sergey Kopienko <[email protected]>
…fix Kernel names Signed-off-by: Sergey Kopienko <[email protected]>
…rename template parameter names in __parallel_merge_submitter Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
…fix review comment Signed-off-by: Sergey Kopienko <[email protected]>
…fix review comment Signed-off-by: Sergey Kopienko <[email protected]>
…introduce __starting_size_limit_for_large_submitter into __parallel_merge Signed-off-by: Sergey Kopienko <[email protected]>
…renames Signed-off-by: Sergey Kopienko <[email protected]>
…introduce _split_point_t type Signed-off-by: Sergey Kopienko <[email protected]>
…remove usages of std::make_pair Signed-off-by: Sergey Kopienko <[email protected]>
…optimize evaluation of split-points on base diagonals Signed-off-by: Sergey Kopienko <[email protected]>
…renames Signed-off-by: Sergey Kopienko <[email protected]>
…extract eval_split_points_for_groups function Signed-off-by: Sergey Kopienko <[email protected]>
…extract run_parallel_merge function Signed-off-by: Sergey Kopienko <[email protected]>
…using SLM bank size to define chunk in the eval_nd_range_params function Signed-off-by: Sergey Kopienko <[email protected]>
…using SLM bank size to define chunk in the eval_nd_range_params function (16) Signed-off-by: Sergey Kopienko <[email protected]>
…restore old implementation of __find_start_point Signed-off-by: Sergey Kopienko <[email protected]>
…rename: base_diag_part -> steps_between_two_base_diags Signed-off-by: Sergey Kopienko <[email protected]>
…fix review comment Signed-off-by: Sergey Kopienko <[email protected]>
…fix an error in __parallel_merge_submitter_large::eval_split_points_for_groups Signed-off-by: Sergey Kopienko <[email protected]>
…onals is too short Signed-off-by: Sergey Kopienko <[email protected]>
…erge_submitter_large` into one `__parallel_merge_submitter` (#1956)
…fix review comment: remove extra condition check from __find_start_point_in Signed-off-by: Sergey Kopienko <[email protected]>
…fix review comment: fix condition check in __find_start_point_in Signed-off-by: Sergey Kopienko <[email protected]>
…apply GitHUB clang format Signed-off-by: Sergey Kopienko <[email protected]>
mmichel11
reviewed
Jan 26, 2025
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge_sort.h
Outdated
Show resolved
Hide resolved
….h - fix review comment: It looks like we just write to the scratch buffer
…rge_sort.h - fix review comment: remove condition check in __lookup_sp" This reverts commit 7488c94.
….h - fix self review comment: redesign work with base diagonals
….h - fix review comment: remove postfix _w from function names inside __merge_sort_global_submitter class
….h - fix self review comment: redesign work with base diagonals
….h - additional comment
….h - additional comment
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge_sort.h
Outdated
Show resolved
Hide resolved
….h - fix review comment
….h - fix review comment
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge_sort.h
Outdated
Show resolved
Hide resolved
….h - fix review comment
….h - additional TODO
danhoeflinger
previously approved these changes
Jan 27, 2025
FYI: The performance has been checked, no issue detected. |
danhoeflinger
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we extends the approach from #1933 to
merge_sortalgorithm.