Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] SVE Implementation of sumWithSIMD #3079

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rakshithgb-fujitsu
Copy link
Contributor

@rakshithgb-fujitsu rakshithgb-fujitsu commented Feb 17, 2025

Implementation of sumWithSIMD for double and float in SVE. This implementation also enables multithreading of this function on ARM with SVE (previously this path was enabled only for intel compiler on x86). This PR achieves almost 3.3x speed up over the original for Linear Regression (tested on AWS Graviton m7g.8x). Even Ridge regression takes advantage of this improvement.

image

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@rakshithgb-fujitsu rakshithgb-fujitsu changed the title SVE Implementation of sumWithSIMD [enhancement] SVE Implementation of sumWithSIMD Feb 20, 2025
@Vika-F
Copy link
Contributor

Vika-F commented Feb 20, 2025

/intelci: run

@Vika-F
Copy link
Contributor

Vika-F commented Feb 24, 2025

Please use clang-format 14.0 (can be installed using pip) to fix the formatting.

@Vika-F
Copy link
Contributor

Vika-F commented Feb 24, 2025

/intelci: run

@rakshithgb-fujitsu
Copy link
Contributor Author

Please use clang-format 14.0 (can be installed using pip) to fix the formatting.

I did use clang-format-14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants