Repository navigation
fix(storybook): replace undefined @0.25 @0.5 chat-message padding with spacing tokens - #319
Merged
Merged
Conversation
The chat-message action-button padding used raw numeric compound @-refs (@0.25 @0.5) which resolve to undefined var(--0--25) var(--0--5). Replace with defined @spacing.2xs @spacing.xs (0.25rem 0.5rem), matching the intended pill padding and the file's sibling token usage.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the undefined
@0.25 @0.5padding on.chat-message-action-buttonwith defined named spacing tokens (@spacing.2xs @spacing.xs) in the chat-message story fixture.Why
@0.25/@0.5are undefined variables — a raw numeric compound@-shorthand that silently resolves tovar(--0--25) var(--0--5). This was the last such undefined compound ref in the storybook build. Once SF-13 (#316) lands, resolving these throws and the storybook build fails, so this fixture had to be corrected first.2xs= 0.25rem andxs= 0.5rem preserve the intended pill padding exactly, and match the file's sibling token usage (the neighboringgapuses@spacing.xs). Implements SF-35.How verified
Notes
Storybook-only change (apps/storybook is in the changeset ignore list) — no changeset. Scope is this one file; the engine breaking-change that turns these refs into a hard throw is SF-13/#316.