Repository navigation
SF-27: clear 6 apps/shared type errors (blocks docs typecheck) - #311
Merged
Merged
Conversation
Declare the previously-undeclared deps that `nuxt typecheck` surfaced when traversing apps/docs -> apps/shared, and fix two module-config typings: - add `git-url-parse`, `pkg-types`, `vue` to apps/shared deps (catalog:nuxt). git-url-parse@16 ships its own `lib/index.d.ts`, so no @types stub is needed (the @types/git-url-parse package is a deprecated no-op). - app/plugins/i18n.ts: type the public i18n runtime config so `defaultLocale` resolves off `{}`. - modules/config.ts: guard `nuxt.options.site` (`false | ModuleOptions`) before reading `.name`, and assert the defu result back to the site type. Stage 1 of SF-26. apps/docs untouched (Stage 2, Larousse).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 1 of SF-26. Clears the 6 pre-existing
apps/sharedtype errors thatnuxt typechecksurfaces when it traversesapps/docs→apps/shared. These paths are unchecked today, so the fixes are strictly additive and this PR is green on its own. Once merged, Stage 2 (Larousse, SF-28) clears the 24 docs errors + folds in the typecheck wiring to flip docs green.Changes (all in
apps/shared/**)Undeclared deps —
nuxt typecheckreported module-not-found for imports that were never declared:git-url-parse,pkg-types(used byutils/git.ts) andvue(used bycomponents/MorphingGradientBackground.vue) added toapps/shared/package.jsonascatalog:nuxt(matching the versionsapps/docsalready pins).@types/*added.git-url-parse@16ships its ownlib/index.d.ts;@types/git-url-parseis a deprecated no-op stub.pkg-typesships its own types too.Typing:
app/plugins/i18n.ts— the public i18n runtime config was typed{}; annotated it sodefaultLocaleresolves.modules/config.ts—nuxt.options.siteisfalse | ModuleOptions; guard for the object case before reading.name, and assert thedefuresult back to the site type (runtime value is a valid site config; the incompatibility isMaybeComputedRef/null variance only).apps/docs/**is untouched — that's Stage 2.Test plan
pnpm --filter @styleframe/docs typecheck— reproduced via a temporary docs wiring (script +vue-tsc, reverted before commit): 0apps/sharederrors remain; only the 24 pre-existing docs errors are left for Stage 2. No new errors introduced in shared.pnpm format:check(oxfmt) — clean on changed files.oxlint apps/shared/— clean.git-url-parse@16.1.0resolves types without the deprecated@typesstub.No changeset —
apps/sharedis an internal Nuxt layer (consumed via workspace, not published); consistent with priorapps/sharedhistory.