Skip to content

Conversation

@ryan-n-gunawan
Copy link
Collaborator

Notion ticket link

Intake Form - make some fields not required

Implementation description

  • Just made fields in form not required for form submission
  • Backend doesn't error when null values are sent, and database columns are all nullable.

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Collaborator

@YashK2005 YashK2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Should be good to merge once you resolve the merge conflicts or rebase onto main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants