Add Housing Monitor #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added leakage detection in powerManagement.c
poornack
requested changes
Jul 9, 2020
| void housingMonitor_run(void) | ||
| { | ||
| housingMonitor_housing_E housing = Main; | ||
| if (housingMonitor_getHousingStatus(housing) == Leak) |
Contributor
There was a problem hiding this comment.
If the ADC value goes above the threshold, then back down, we want to latch the housing status to leak in case the water is just sloshing around in the housing.
My recommendation is to have a variable in this module's data struct that holds the housing status. Update it every time housingMonitor_run is run. When housingMonitor_getHousingStatus is called by another file, just return the value of that variable.
Modified the code according to ccomments
Contributor
|
Has this PR been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added leakage detection in powerManagement.c