Skip to content

fix(app): prevent startup info modal from obscuring the set-new-password flow#857

Merged
antontranelis merged 3 commits into
mainfrom
copilot/fix-password-reset-dialog-overlap
May 7, 2026
Merged

fix(app): prevent startup info modal from obscuring the set-new-password flow#857
antontranelis merged 3 commits into
mainfrom
copilot/fix-password-reset-dialog-overlap

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

When a map is configured with info_open, the startup info dialog could appear on top of the password reset flow and hide the set-new-password overlay. This change scopes the startup modal behavior to the root map route so auth overlays remain visible.

  • Route-aware startup modal behavior

    • Restrict auto-opening of the info modal to /
    • Stop carrying that startup modal onto non-root routes like /set-new-password
    • Only auto-close the modal when it was opened by the startup behavior itself
  • Regression coverage

    • Add a focused Cypress spec for the password reset route with info_open: true
    • Verify the inverse behavior still holds on /: the startup info modal continues to open on the root route
  • Behavioral outline

    if (map.info_open && pathname === ROOT_PATH && !myModal.open) {
      myModal.showModal()
      autoOpenedModal.current = true
      return
    }
    
    if (pathname !== ROOT_PATH && autoOpenedModal.current && myModal.open) {
      myModal.close()
      autoOpenedModal.current = false
    }

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5263 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.xWRfhL --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1401207645336904051,13481738809321490767,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9497358491770056846,6400152126438246467,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5264 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.01l8YG --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5262842145553801669,4511469155538847023,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15492420667201303348,16203571616078300475,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --no-sandbox --disable-gpu --window-size=1280,720 --virtual-time-budget=8000 --screenshot=/tmp/set-new-password-route.png REDACTED --depth 2 REDACTED git conf�� .11.1 check --global ules/.bin/sh gpg.program (dns block)
  • android.clients.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5537 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.X5ch0f --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15670471316369335900,13722498977471960121,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,3948516240005888738,1379856129877171555,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --no-sandbox --disable-gpu --virtual-time-budget=8000 --dump-dom REDACTED sh credential.usernnode (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5264 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.01l8YG --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5262842145553801669,4511469155538847023,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15492420667201303348,16203571616078300475,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5263 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.xWRfhL --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1401207645336904051,13481738809321490767,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9497358491770056846,6400152126438246467,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --no-sandbox --disable-gpu --window-size=1280,720 --virtual-time-budget=8000 --screenshot=/tmp/set-new-password-route.png REDACTED --depth 2 REDACTED git conf�� .11.1 check --global ules/.bin/sh gpg.program (dns block)
  • download.cypress.io
    • Triggering command: /usr/local/bin/node node dist/index.js --exec install (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5263 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.xWRfhL --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1401207645336904051,13481738809321490767,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9497358491770056846,6400152126438246467,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5264 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.01l8YG --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5262842145553801669,4511469155538847023,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15492420667201303348,16203571616078300475,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --no-sandbox --disable-gpu --virtual-time-budget=8000 --dump-dom REDACTED cal/bin/git --depth 2 REDACTED git conf�� .11.1 check --global node_modules/.bin/sh ofileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,Automat (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5264 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.01l8YG --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5262842145553801669,4511469155538847023,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15492420667201303348,16203571616078300475,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5263 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.xWRfhL --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,1401207645336904051,13481738809321490767,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,9497358491770056846,6400152126438246467,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --no-sandbox --disable-gpu --virtual-time-budget=8000 --dump-dom REDACTED cal/bin/git --depth 2 REDACTED git conf�� .11.1 check --global node_modules/.bin/sh ofileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,AutoDeElevate,Automat (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Agent-Logs-Url: https://github.com/utopia-os/utopia-map/sessions/67d1c62c-2aa3-40ca-a223-5a0b94cc34ac

Co-authored-by: antontranelis <31516529+antontranelis@users.noreply.github.com>
@antontranelis antontranelis marked this pull request as ready for review May 7, 2026 11:48
Agent-Logs-Url: https://github.com/utopia-os/utopia-map/sessions/67d1c62c-2aa3-40ca-a223-5a0b94cc34ac

Co-authored-by: antontranelis <31516529+antontranelis@users.noreply.github.com>
@antontranelis antontranelis changed the title [WIP] Fix overlapping info popup during password reset fix(app): fix overlapping info popup during password reset May 7, 2026
Copilot AI changed the title fix(app): fix overlapping info popup during password reset Prevent startup info modal from obscuring the set-new-password flow May 7, 2026
Copilot AI requested a review from antontranelis May 7, 2026 11:53
@antontranelis antontranelis changed the title Prevent startup info modal from obscuring the set-new-password flow fix(app): prevent startup info modal from obscuring the set-new-password flow May 7, 2026
@antontranelis antontranelis merged commit 8aa1426 into main May 7, 2026
29 of 30 checks passed
@antontranelis antontranelis deleted the copilot/fix-password-reset-dialog-overlap branch May 7, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] overlapping info popup during password reset

2 participants