test: add unit tests for llm/utils module#173
Open
Jeong-Ryeol wants to merge 1 commit intousestrix:mainfrom
Open
test: add unit tests for llm/utils module#173Jeong-Ryeol wants to merge 1 commit intousestrix:mainfrom
Jeong-Ryeol wants to merge 1 commit intousestrix:mainfrom
Conversation
Following up on @0xallam's comment on usestrix#157: > "I think we need to add even more unit tests now, especially to the most critical parts of the agent." This PR adds tests for `llm/utils.py` - the core LLM response parsing logic. Addresses usestrix#158 What's included: - TestParseToolInvocations: XML tool invocation parsing (8 tests) - TestFixStopword: Incomplete function tag handling (4 tests) - TestFormatToolCall: Tool call XML formatting (4 tests) - TestCleanContent: Content cleaning and XML removal (6 tests) - TestTruncateToFirstFunction: First function truncation (4 tests) Total: 26 tests, all passing.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on @0xallam's comment on #157:
This PR adds tests for
llm/utils.py- the core LLM response parsing logic.Addresses #158
What's included
TestParseToolInvocationsTestFixStopwordTestFormatToolCallTestCleanContentTestTruncateToFirstFunctionTotal: 26 tests, all passing.
Test plan
test_argument_parser.pyNext steps (if this direction looks good)
I'm planning to continue adding tests for other critical modules:
agents/state.pyllm/memory_compressor.pytools/executor.pyHappy to adjust priorities based on your feedback!